Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Added extra time for tx distribution at shard level only for first epoch #2566

Merged
merged 1 commit into from
May 20, 2021
Merged

[master] Added extra time for tx distribution at shard level only for first epoch #2566

merged 1 commit into from
May 20, 2021

Conversation

sandipbhoir
Copy link
Contributor

@sandipbhoir sandipbhoir commented May 19, 2021 •
edited

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@sandipbhoir sandipbhoir added the Untested Haven't been tested yet label May 19, 2021
@sandipbhoir sandipbhoir self-assigned this May 19, 2021
@github-actions github-actions bot changed the title Added extra time for tx distribution at shard level only for first epoch [master] Added extra time for tx distribution at shard level only for first epoch May 19, 2021
@github-actions github-actions bot added this to PRs in development in Core May 19, 2021
@sandipbhoir sandipbhoir added Testing_InProgress and removed Untested Haven't been tested yet labels May 20, 2021
chetan-zilliqa
chetan-zilliqa reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@chetan-zilliqa chetan-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need not to have extra_time in NotifyTimeout , WaitUntilTxnProcessingDone and WaitUntilCompleteMicroBlockIsReady functions ?

@chetan-zilliqa chetan-zilliqa self-requested a review May 20, 2021 04:15
@sandipbhoir sandipbhoir added Ready Ready for review and removed Testing_InProgress labels May 20, 2021
@sandipbhoir
Copy link
Contributor Author

Do we need not to have extra_time in NotifyTimeout , WaitUntilTxnProcessingDone and WaitUntilCompleteMicroBlockIsReady functions ?

We dont want to reduce time for txn processing.

Core automation moved this from PRs in development to PRs approved - ready to merge! May 20, 2021
@sandipbhoir sandipbhoir merged commit 8412efa into master May 20, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) May 20, 2021
@sandipbhoir sandipbhoir deleted the fix/txpktdelayatds branch May 20, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb111189 bb111189 bb111189 approved these changes

@chetan-zilliqa chetan-zilliqa chetan-zilliqa approved these changes

@KaustubhShamshery KaustubhShamshery Awaiting requested review from KaustubhShamshery

Assignees

@sandipbhoir sandipbhoir

Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandipbhoir @bb111189 @chetan-zilliqa