[master] Add code of pending txn in hashing #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
KaustubhShamshery
requested review from
sandipbhoir,
chetan-zilliqa and
sunny-teo9000
sandipbhoir
approved these changes
May 27, 2021
chetan-zilliqa
approved these changes
May 27, 2021
sunny-teo9000
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backward Compatibility
Review Suggestion
Status
Implementation
Issue: The pending hash just had the txn list, hence if the code of the pending txn changes, it might be marked as duplicate and be rejected.
Integration Test (Core Team)