[master] Avoid fetching BlockChainData(historical MB/TxBodies) for seeds/lookups in case of rejoin from S3 #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandipbhoir
requested review from
bb111189,
KaustubhShamshery,
chetan-zilliqa and
sunny-teo9000
github-actions
bot
changed the title
sunny-teo9000
approved these changes
Jun 2, 2021
chetan-zilliqa
approved these changes
Jun 2, 2021
rigan0707
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses : https://github.com/Zilliqa/Issues/issues/732
Now, seeds/lookup on Rejoin from S3, will not fetch data from bucket
blockchain-datainstead will reuse the one stored earlier at startup of node.Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)