Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Set limit on querying DS Block #2593

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

sunny-teo9000
Copy link

@sunny-teo9000 sunny-teo9000 commented Jun 8, 2021

Description

To limit the amount of DS blocks being retrieved from ProcessGetDSBlockFromSeed
https://github.com/Zilliqa/Issues/issues/686

Any call for RetrieveDSBlocks that is not partial will be limit to FETCH_DS_BLOCK_LIMIT of blocks starting from lowBlockNum

Backward Compatibility

  • This is not a breaking change
  • [] This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@github-actions github-actions bot changed the title Set limit on querying DS Block (To be tested) [master] Set limit on querying DS Block (To be tested) Jun 8, 2021
@github-actions github-actions bot added this to PRs in development in Core Jun 8, 2021
@sunny-teo9000 sunny-teo9000 changed the title [master] Set limit on querying DS Block (To be tested) [master] Set limit on querying DS Block Jun 9, 2021
constants.xml Outdated Show resolved Hide resolved
src/libLookup/Lookup.cpp Outdated Show resolved Hide resolved
src/libLookup/Lookup.cpp Outdated Show resolved Hide resolved
src/libLookup/Lookup.cpp Outdated Show resolved Hide resolved
src/libLookup/Lookup.cpp Outdated Show resolved Hide resolved
Core automation moved this from PRs in development to PRs needing review Jun 10, 2021
Core automation moved this from PRs needing review to PRs approved - ready to merge! Jun 10, 2021
@sandipbhoir sandipbhoir merged commit ddc38cf into master Jun 10, 2021
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jun 10, 2021
@sandipbhoir sandipbhoir deleted the feature/dsblockquerylimit branch June 10, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants