[master] Purge MPT roots for normal node #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
sandipbhoir
suggested changes
Jun 13, 2021
KaustubhShamshery
force-pushed
the
feauture/MPT/purge_normal_node
branch
from
49f5fe8
to
c668b83
Compare
sandipbhoir
approved these changes
Jun 13, 2021
chetan-zilliqa
approved these changes
Jun 14, 2021
src/libZilliqa/Zilliqa.cpp
Outdated
| @@ -236,6 +236,7 @@ Zilliqa::Zilliqa(const PairOfKey& key, const Peer& peer, SyncType syncType, | |||
| if (!AccountStore::GetInstance().RefreshDB()) { | |||
| LOG_GENERAL(WARNING, "AccountStore::RefreshDB failed"); | |||
| } | |||
| AccountStore::GetInstance().PurgeUnnecessary(); | |||
There was a problem hiding this comment.
Is this function meant to be called for seedpubs or seedprvs or seednodes?
There was a problem hiding this comment.
No, got your point, making changes
KaustubhShamshery
force-pushed
the
feauture/MPT/purge_normal_node
branch
from
c668b83
to
672f858
Compare
KaustubhShamshery
force-pushed
the
feauture/MPT/purge_normal_node
branch
from
5f535f4
to
ff41b64
Compare
KaustubhShamshery
force-pushed
the
feauture/MPT/purge_normal_node
branch
from
ff41b64
to
fcd55c7
Compare
sandipbhoir
approved these changes
Jun 14, 2021
KaustubhShamshery
changed the title
chetan-zilliqa
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add purging of historical data for normal node (non-lookup)
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)