[release-8.1] Handle pows received before POW_SUBMISSION state #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandipbhoir
requested review from
bb111189,
KaustubhShamshery and
chetan-zilliqa
github-actions
bot
changed the title
chetan-zilliqa
approved these changes
Jun 25, 2021
| @@ -285,18 +292,16 @@ void DirectoryService::ProcessFinalBlockConsensusWhenDone() { | |||
| } | |||
| m_mediator.m_node->ClearUnconfirmedTxn(); | |||
|
|
|||
| AccountStore::GetInstance().InitTemp(); | |||
| AccountStore::GetInstance().InitRevertibles(); | |||
There was a problem hiding this comment.
was this change intended?
There was a problem hiding this comment.
Yes. Basically we reverted the previous change. Now, Expiry window flag & state check in ProcessPowSubmission will allow submission to be accepted while node is still FinalBlockConsensus state
KaustubhShamshery
approved these changes
Jun 29, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)