Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-8.1] Fix State disappearing after a revert #2645

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

KaustubhShamshery
Copy link
Contributor

@KaustubhShamshery KaustubhShamshery commented Jul 9, 2021

Description

during updation, the state values were being stored in p_*, however this caused updated states to be deleted.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@github-actions github-actions bot added this to PRs in development in Core Jul 9, 2021
@github-actions github-actions bot changed the title Fix State disappearing after a revert [release-8.1] Fix State disappearing after a revert Jul 9, 2021
@KaustubhShamshery KaustubhShamshery self-assigned this Jul 9, 2021
@KaustubhShamshery KaustubhShamshery added the Ready Ready for review label Jul 9, 2021
@bb111189
Copy link
Contributor

bb111189 commented Jul 9, 2021

may need to clean the contants xml changes

Core automation moved this from PRs in development to PRs approved - ready to merge! Jul 9, 2021
@sandipbhoir sandipbhoir merged commit 5c2f0c1 into release-8.1 Jul 10, 2021
@sandipbhoir sandipbhoir deleted the fix/8.1/state_disappearing branch July 10, 2021 04:17
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants