Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-8.1] Store Every Hash #2672

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

KaustubhShamshery
Copy link
Contributor

@KaustubhShamshery KaustubhShamshery commented Jul 23, 2021

Description

Do not remove any roothash before expiry. (even if it is not refrenced)

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@github-actions github-actions bot added this to PRs in development in Core Jul 23, 2021
@github-actions github-actions bot changed the title Store Every Hash [release-8.1] Store Every Hash Jul 23, 2021
@KaustubhShamshery KaustubhShamshery self-assigned this Jul 28, 2021
@sandipbhoir sandipbhoir added the Ready Ready for review label Jul 28, 2021
Core automation moved this from PRs in development to PRs approved - ready to merge! Jul 28, 2021
fix inserted

add more checks

put in db for later purging

fix increment pointer

avoid adding empty entry for key in kill
@sandipbhoir sandipbhoir merged commit a8f64e4 into release-8.1 Aug 1, 2021
@sandipbhoir sandipbhoir deleted the fix/8.1/store_every_hash branch August 1, 2021 02:32
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants