Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-8.1] Limit fetching for DirBlocks #2680

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

sandipbhoir
Copy link
Contributor

same as #2679

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

minor refactoring

set constant to 1
@sandipbhoir sandipbhoir added the Ready Ready for review label Jul 29, 2021
@sandipbhoir sandipbhoir self-assigned this Jul 29, 2021
@github-actions github-actions bot changed the title Limit fetching for DirBlocks [release-8.1] Limit fetching for DirBlocks Jul 29, 2021
@github-actions github-actions bot added this to PRs in development in Core Jul 29, 2021
Copy link
Contributor

@chetan-zilliqa chetan-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandipbhoir ,so, we are reducing the limit to 1 to allow fetch only one directory block in the release branch.

Core automation moved this from PRs in development to PRs approved - ready to merge! Jul 29, 2021
@sandipbhoir sandipbhoir merged commit fdfafd2 into release-8.1 Jul 29, 2021
@sandipbhoir sandipbhoir deleted the fix/8.1/limitgetdir branch July 29, 2021 11:49
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants