[release-8.1] Remove partialRetrieve from RetrieveDSBlocks #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny-teo9000
requested review from
sandipbhoir,
chetan-zilliqa,
bb111189 and
KaustubhShamshery
github-actions
bot
changed the title
src/libLookup/Lookup.cpp
Outdated
| @@ -1860,16 +1860,14 @@ void Lookup::RetrieveDSBlocks(vector<DSBlock>& dsBlocks, uint64_t& lowBlockNum, | |||
| lowBlockNum = 1; | |||
| } | |||
|
|
|||
| lowBlockNum = partialRetrieve ? max(minBlockNum, lowBlockNum) | |||
| : min(minBlockNum, lowBlockNum); | |||
| lowBlockNum = max(minBlockNum, lowBlockNum); | |||
There was a problem hiding this comment.
I think can remove this max/min logic itself, lowBlocknum is what it should be
sunny-teo9000
force-pushed
the
fix/remove-var-partial-retriever
branch
from
bb5e530
to
68537c9
Compare
sunny-teo9000
force-pushed
the
fix/remove-var-partial-retriever
branch
from
68537c9
to
c92315f
Compare
sandipbhoir
approved these changes
Aug 19, 2021
chetan-zilliqa
approved these changes
Aug 19, 2021
KaustubhShamshery
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove partialRetrieve bool from RetrieveDSBlocks
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)