[release-8.1] Add extra txn distribution time before FB consensus when no shard #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandipbhoir
requested review from
bb111189,
KaustubhShamshery and
chetan-zilliqa
github-actions
bot
changed the title
sandipbhoir
changed the title
bb111189
approved these changes
Aug 19, 2021
chetan-zilliqa
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
@sandipbhoir, Just to understand, we have received DSMBMISSINGTXN for the ANNOUNCEresponse in yesterday's mainnet issue, so are we addressing the issue of missing txn's by increasing the transaction distribution window from current 6 secs to 15 secs, so that all DSgurads have a same number of txns.
sandipbhoir
added
Testing_InProgress
and removed
Untested
sandipbhoir
force-pushed
the
fix/txndisttimewindow
branch
from
3f6f634
to
6eb0585
Compare
Added packet sending delay from lookup to time window detach the executuon of finalblockconsensus startup when no shard
KaustubhShamshery
approved these changes
Aug 19, 2021
chetan-zilliqa
approved these changes
Aug 20, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue:
https://github.com/Zilliqa/Issues/issues/743
https://github.com/Zilliqa/Issues/issues/744
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)