[master] Make scilla tests parallel-friendly. #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llel-tests/add-scilla-tests
github-actions
bot
changed the title
rrw-zilliqa
approved these changes
Sep 27, 2023
| @@ -11,13 +12,15 @@ export type DeployOptions = { | |||
|
|
|||
| export class Parallelizer { | |||
| constructor() { | |||
| let privateKey = "254d9924fc1dcdca44ce92d80255c6a0bb690f867abde80e626fbfef4d357004"; | |||
| let privateKey = "d96e9eb5b782a80ea153c937fa83e5948485fbfc8b7e7c069d7b914dbc350aba"; | |||
There was a problem hiding this comment.
Might want to consider commenting on why it's safe to quote this private key here..
There was a problem hiding this comment.
It's removed in the latest commit.
…llel-tests/add-scilla-tests
…llel-tests/add-scilla-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)