Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] ZIL-5447: Implement header hash customisation for remote miners #3857

Merged
merged 2 commits into from Nov 9, 2023

Conversation

JamesHinshelwood
Copy link
Contributor

See Zilliqa/zilliqa-developer#262 for documentation of the interface.

@github-actions github-actions bot changed the title ZIL-5447: Implement header hash customisation for remote miners [master] ZIL-5447: Implement header hash customisation for remote miners Oct 31, 2023
@github-actions github-actions bot added this to PRs in development in Core Oct 31, 2023
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the constructor issue..

src/libMessage/Messenger.cpp Outdated Show resolved Hide resolved
src/libMessage/Messenger.cpp Outdated Show resolved Hide resolved
src/libMessage/Messenger.cpp Outdated Show resolved Hide resolved
src/libMessage/Messenger.cpp Outdated Show resolved Hide resolved
Core automation moved this from PRs in development to PRs needing review Nov 3, 2023
rrw-zilliqa
rrw-zilliqa previously approved these changes Nov 8, 2023
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

Core automation moved this from PRs needing review to PRs approved - ready to merge! Nov 8, 2023
Core automation moved this from PRs approved - ready to merge! to PRs needing review Nov 9, 2023
@JamesHinshelwood JamesHinshelwood enabled auto-merge (squash) November 9, 2023 09:55
Core automation moved this from PRs needing review to PRs approved - ready to merge! Nov 9, 2023
@JamesHinshelwood JamesHinshelwood merged commit 3c4e999 into master Nov 9, 2023
4 checks passed
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Nov 9, 2023
@JamesHinshelwood JamesHinshelwood deleted the zil-5447 branch November 9, 2023 14:31
chetan-zilliqa added a commit that referenced this pull request Nov 10, 2023
* [master] Support legacy transactions without replay protection. (#3847)

* Increase initial funds of signers (#3860)

* Support creating signers using a zil-based account in setup script (#3861)

* Support creating signers using a zil-based account in setup script

* Move SignerHelpers to helpers folder

* Fix some compilation error

* Add refund signers task

* Update setup task

* update config

* (fix) ZIL-5457: Don't segfault when asked for a block after the end of the chain (plus some additional protection for illformed internal calls). (#3856)

* DEVOPS-1093: Pass along otterscan options so that zblockchain can tell localdev what to ask testnet to do. (#3863)

* [master] Make setup script more user-friendly.  (#3862)

* [master] Proper check for receiving announce msg early (#3864)

* Proper check for receiving announce msg early

* Proper check for receiving announce msg early (2)

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Change balances task so that it gets balances in parallel. (#3866)

* Change blaances task so that it gets balances in parallel

* run lint

* Return 0x0 if the signature passed to eth_sendRawTransaction is invalid. (#3867)

* [master] Zil 5473 localdev changes gossip (#3869)

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.
Move change of commit_window to localdev and not the constants.xml

* Shuffle signers to use them evenly in tests. (#3868)

* [master] ZIL-5447: Implement header hash customisation for remote miners (#3857)

* ZIL-5447: Implement header hash customisation for remote miners

* ZIL-5447: Fix out-of-bounds iterator access

---------

Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: James Hinshelwood <JamesHinshelwood@users.noreply.github.com>
chetan-zilliqa pushed a commit that referenced this pull request Nov 14, 2023
…ers (#3857)

* ZIL-5447: Implement header hash customisation for remote miners

* ZIL-5447: Fix out-of-bounds iterator access
bzawisto added a commit that referenced this pull request Nov 21, 2023
* Update release version to v9.3.0rc0

* Tweak constants for blocktime and txn distribution (#3838)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823) (#3840)

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>

* Update release version to v9.3.0rc1 (#3841)

* [release/v9.3] Merge master to release/v9.3 (#3843)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc0

* Update release version to v9.3.0rc1 (#3841)

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc2 (#3844)

* [master] ZIL-5406: add support for a cdn (#3848)

* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.

* Update version to v9.3.0rc3.

* [release/v9.3] release v9.3.0rc4 preparation (#3853)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Zil 5450 network native tests improve (#3845)

* chore: update response stats for debugging

* Add logs when txn forwarding happens

* Fix for mismatch in txn pool data

* Some helpful addons

* Fixing cosig retrieval

* Fixes

* Remove unnecessary logging

* Adding more logging

* More logs

* Followup investigation

* Another one

* Hard revert

* Close socket

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* updates and experiment
Renamed branch to help ci

* updates and experiment
Renamed branch to help ci

---------

Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] ZIL-5406: add support for a cdn (#3848)

* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.

* Fixes to the scripts and startups - does not touch cpp files. (#3849)

* Fix CI issue regarding installing nodejs (#3852)

* feat: update Zilliqa SW version

* Adding more helpful logs and remove unneeded peer check (#3846)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: Yaron <yaron@zilliqa.com>
Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>

* Update the version to v9.3.0rc5

* Adding more helpful logging

* Adding more helpful logs

* Accept new connection regardless of current error

* Missing file:

* Add more logging

* Add heartbeat timer for p2p connections

* Fix

* Minor fix

* Some fixes

* Use async dns lookups if needed

* Better logging

* fix merge problem

* log both commit and response audit

* Some additional fixes

* Make one log infoed

* More logs

* Leader always sends block

* Don't expire messages for dns-like nodes too early

* More logs

* Missing port

* Fix

* Don't log

* [master] Zil 5473 localdev changes gossip (#3869)

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.
Move change of commit_window to localdev and not the constants.xml

* Shuffle signers to use them evenly in tests. (#3868)

* [master] ZIL-5447: Implement header hash customisation for remote miners (#3857)

* ZIL-5447: Implement header hash customisation for remote miners

* ZIL-5447: Fix out-of-bounds iterator access

* US-322: ots_hasCode() should take an integer as its second argument. (#3871)

* Update version to v9.3.0rt1

* Revert "Leader always sends block"

This reverts commit 8e2fe84.

* Printing lookup list

* Another helpful printf

* More logs

* kick

* Update before install

* Timers

* Print remote it couldn't connect to

* Normalizing constants, adding comment

* Cleanup

* Cleanup

* kick

---------

Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Yaron <yaron@zilliqa.com>
Co-authored-by: Mauro Medda <mauromedda@users.noreply.github.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: James Hinshelwood <JamesHinshelwood@users.noreply.github.com>
bzawisto added a commit that referenced this pull request Dec 6, 2023
* Update release version to v9.3.0rc0

* Tweak constants for blocktime and txn distribution (#3838)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823) (#3840)

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>

* Update release version to v9.3.0rc1 (#3841)

* [release/v9.3] Merge master to release/v9.3 (#3843)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc0

* Update release version to v9.3.0rc1 (#3841)

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc2 (#3844)

* [master] ZIL-5406: add support for a cdn (#3848)

* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.

* Update version to v9.3.0rc3.

* [release/v9.3] release v9.3.0rc4 preparation (#3853)

* (feat) ZIL-5423: Deployment instructions for reward control contracts. (#3823)

* Tweak constants for blocktime and txn distribution (#3839)

* Fixing double enter into consensus in case gossip arrives early (#3842)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Zil 5450 network native tests improve (#3845)

* chore: update response stats for debugging

* Add logs when txn forwarding happens

* Fix for mismatch in txn pool data

* Some helpful addons

* Fixing cosig retrieval

* Fixes

* Remove unnecessary logging

* Adding more logging

* More logs

* Followup investigation

* Another one

* Hard revert

* Close socket

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* Save the changes that have been tested and verified

* updates and experiment
Renamed branch to help ci

* updates and experiment
Renamed branch to help ci

---------

Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] ZIL-5406: add support for a cdn (#3848)

* Make the bucket name in localdev.py configurable.
* Update download & upload scripts to use a CDN.

* Fixes to the scripts and startups - does not touch cpp files. (#3849)

* Fix CI issue regarding installing nodejs (#3852)

* feat: update Zilliqa SW version

* Adding more helpful logs and remove unneeded peer check (#3846)

Co-authored-by: bzawisto <bartosz@zilliqa.com>

---------

Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: Yaron <yaron@zilliqa.com>
Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>

* Update the version to v9.3.0rc5

* [release/v9.3] Merge master to release/v9.3 (#3865)

* [master] Support legacy transactions without replay protection. (#3847)

* Increase initial funds of signers (#3860)

* Support creating signers using a zil-based account in setup script (#3861)

* Support creating signers using a zil-based account in setup script

* Move SignerHelpers to helpers folder

* Fix some compilation error

* Add refund signers task

* Update setup task

* update config

* (fix) ZIL-5457: Don't segfault when asked for a block after the end of the chain (plus some additional protection for illformed internal calls). (#3856)

* DEVOPS-1093: Pass along otterscan options so that zblockchain can tell localdev what to ask testnet to do. (#3863)

* [master] Make setup script more user-friendly.  (#3862)

* [master] Proper check for receiving announce msg early (#3864)

* Proper check for receiving announce msg early

* Proper check for receiving announce msg early (2)

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* Update release version to v9.3.0rc6

---------

Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [release/v9.3] Merge master to release/v9.3 branch (#3870)

* [master] Support legacy transactions without replay protection. (#3847)

* Increase initial funds of signers (#3860)

* Support creating signers using a zil-based account in setup script (#3861)

* Support creating signers using a zil-based account in setup script

* Move SignerHelpers to helpers folder

* Fix some compilation error

* Add refund signers task

* Update setup task

* update config

* (fix) ZIL-5457: Don't segfault when asked for a block after the end of the chain (plus some additional protection for illformed internal calls). (#3856)

* DEVOPS-1093: Pass along otterscan options so that zblockchain can tell localdev what to ask testnet to do. (#3863)

* [master] Make setup script more user-friendly.  (#3862)

* [master] Proper check for receiving announce msg early (#3864)

* Proper check for receiving announce msg early

* Proper check for receiving announce msg early (2)

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>

* [master] Change balances task so that it gets balances in parallel. (#3866)

* Change blaances task so that it gets balances in parallel

* run lint

* Return 0x0 if the signature passed to eth_sendRawTransaction is invalid. (#3867)

* [master] Zil 5473 localdev changes gossip (#3869)

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.

* Enhance the configuration to allow localdev to operate with gossip mode
start the full set of dameons including prometheus and not hang waiting for ip addresses to be assigned
disable tracing until it has been fully tested.
Enable prometheus only in this version.
Move change of commit_window to localdev and not the constants.xml

* Shuffle signers to use them evenly in tests. (#3868)

* [master] ZIL-5447: Implement header hash customisation for remote miners (#3857)

* ZIL-5447: Implement header hash customisation for remote miners

* ZIL-5447: Fix out-of-bounds iterator access

---------

Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: James Hinshelwood <JamesHinshelwood@users.noreply.github.com>

* Bumping versions

* Update release version to v9.3.0rc9

* Update release version to v9.3.0rc10

* Update release version to v9.3.0rc12

* [release/v9.3] Exclude complete persistence from cdn cache (#3882)

* Exclude complete persistence from cdn cache

* Update release version to v9.3.0rc13

* Update release version to v9.3.0rc14

* Don't print the same thing twice

* fix typo

* More useful comments

* More useful comments (2)

* typo

* Some improvements

* Some improvements (2)

* Slow mongo fixes

* Fixing version

* Another place

* SwInfo fix

* kikc

* Make this debug

* Cleanup

---------

Co-authored-by: Chetan Phirke <chetan@zilliqa.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: Richard Watts <108257153+rrw-zilliqa@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Yaron <yaron@zilliqa.com>
Co-authored-by: Mauro Medda <mauromedda@users.noreply.github.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Saeed Dadkhah <saeed@zilliqa.com>
Co-authored-by: James Hinshelwood <JamesHinshelwood@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

3 participants