Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Allow syncing of ds nodes if they kicked out of ds comm instead of rejoin from scrach #3896

Merged
merged 1 commit into from Dec 11, 2023

Conversation

chetan-zilliqa
Copy link
Contributor

@chetan-zilliqa chetan-zilliqa commented Dec 8, 2023

Description

A DS node is removed from the consensus because of not signing enough blocks or competition performs rejoins. This means it downloads complete persistence and syncs again which is a very time-consuming process. The fix is to allow the node to start syncing to join in the next epoch.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@chetan-zilliqa chetan-zilliqa self-assigned this Dec 8, 2023
@github-actions github-actions bot changed the title Allow syncing of ds nodes if they kicked out of ds comm instead of rejoin from scrach [master] Allow syncing of ds nodes if they kicked out of ds comm instead of rejoin from scrach Dec 8, 2023
@github-actions github-actions bot added this to PRs in development in Core Dec 8, 2023
Core automation moved this from PRs in development to PRs approved - ready to merge! Dec 11, 2023
@chetan-zilliqa chetan-zilliqa merged commit 2d5dc3c into master Dec 11, 2023
6 checks passed
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Dec 11, 2023
@chetan-zilliqa chetan-zilliqa deleted the fix/ZIL-5513-master branch December 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants