Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feedback mechanism for consensus, implemented for microblock consensus missing txns #66

Merged
merged 12 commits into from
Feb 2, 2018

Conversation

sidutta
Copy link
Contributor

@sidutta sidutta commented Jan 26, 2018

TODO: restart announcement from leader with customized proposal

m_commitPointMap(pubkeys.size(), CommitPoint()),
m_commitRedundantMap(pubkeys.size(), false),
m_commitRedundantPointMap(pubkeys.size(), CommitPoint()),
m_responseDataMap(pubkeys.size(), Response())
{
LOG_MARKER();

m_state = INITIAL;
// m_numForConsensus = (floor(TOLERANCE_FRACTION * (pubkeys.size() - 1)) + 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check calculation and write the steps as a comment.

@bb111189 bb111189 mentioned this pull request Feb 2, 2018
Copy link
Contributor

@bb111189 bb111189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. One outstanding task remains. See issue #68

@bb111189 bb111189 merged commit e1cee94 into master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants