Formatter: Support comments
#1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the location of the `Let` node as the start of the `let` keyword in the source code. This is necessary for the formatter implementation.
This is not finished work. We need to support: + top-level comments + comments between components And test it properly. Closes Zilliqa#1086
jubnzv
force-pushed
the
1086_comments
branch
from
0250bd5
to
8db2eaf
Compare
jjcnn
approved these changes
Oct 5, 2022
|
@jjcnn Thanks! I tried the formatter on marketplace-contracts and the formatted code seems good. I also ran it on the dump of all deployed contracts (see #1120) and, at least, it doesn't crush and generates readable code. Of course, there may be cases that we have not taken into account, but we could fix them in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1086