fix(runner): An exception on --help argument
#1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal implementation of `Arg.parse_argv` throws a `Help` exception if it see `-help` or `--help` key. See: https://github.com/ocaml/ocaml/blob/182fd48a41d5bb0ab80089065306342cdc6941c7/stdlib/arg.ml#L160 Closes #1201
jjcnn
approved these changes
Nov 21, 2022
jubnzv
added a commit
that referenced
this pull request
Feb 1, 2023
The internal implementation of `Arg.parse_argv` throws a `Help` exception if it called with `-help` or `--help` key. See: https://github.com/ocaml/ocaml/blob/182fd48a41d5bb0ab80089065306342cdc6941c7/stdlib/arg.ml#L160 Closes #1201 Co-authored-by: jjcnn <38888011+jjcnn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal implementation of
Arg.parse_argvthrows aHelpexception if it see-helpor--helpkey.See: https://github.com/ocaml/ocaml/blob/182fd48a41d5bb0ab80089065306342cdc6941c7/stdlib/arg.ml#L160
Closes #1201