Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md #888

Merged
merged 2 commits into from Oct 1, 2020
Merged

Update INSTALL.md #888

merged 2 commits into from Oct 1, 2020

Conversation

csajedi
Copy link
Contributor

@csajedi csajedi commented Sep 28, 2020

apt installing opam on ubuntu is error prone. Use the official installation script instead

apt installing opam on ubuntu is error prone. Use the official installation script instead
@jjcnn
Copy link
Contributor

jjcnn commented Sep 29, 2020

We should use the official OPAM installation guide (https://opam.ocaml.org/doc/Install.html#Ubuntu), which does indeed list the above solution for Ubuntu version older than 18.04. For 18.04 and newer, though, our installation instructions match the official OPAM recommendation:

add-apt-repository ppa:avsm/ppa
apt update
apt install opam

Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current instructions match the official installation instructions for OPAM on Ubuntu 18.04 and newer. For older versions, the install script is the recommended solution.

@vaivaswatha : Do you happen to have an old Ubuntu system up and running? If not I can probably set up an old Ubuntu system on a laptop later this week, just to make sure we don't mess something up on older systems.

Alternatively we can skip support for pre-18.04 Ubuntu, but we currently do support it, and this doesn't seem like a strong enough argument to drop the support.

@vaivaswatha
Copy link
Contributor

The instructions we have is valid for 16.04 too: we were using it for Docker builds https://github.com/Zilliqa/scilla/pull/872/files until we moved to 18.04.

I don't see why we shouldn't use the PPA, but I am not opposed to adding a remark explicitly mentioning that for systems older than 18.04, the install script can be used.

Use install script only for older than 18.04
@vaivaswatha vaivaswatha merged commit d361059 into Zilliqa:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants