Keep user-defined ADTs after typechecking pass #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since identifiers after this pass need to be annotated with types, we add a dummy type ascription with Unit type.
vaivaswatha
approved these changes
Sep 29, 2020
jjcnn
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
I was trying to play around with changing the entry in Syntax.ml from
| LibTyp of ER.rep SIdentifier.t * ctr_def list
to
| LibTyp of SR.rep SIdentifier.t * ctr_def list
because that would eliminate the need to assign a type to the name of the type.
However, it gets really annoying when checking for duplicate names, so I think we should go for your solution.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since identifiers after this pass need to be annotated
with types, we add a dummy type ascription with
Unittype.