Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for tzil bech32 address #939

Merged
merged 3 commits into from Feb 5, 2021
Merged

Remove support for tzil bech32 address #939

merged 3 commits into from Feb 5, 2021

Conversation

vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented Feb 3, 2021

The spec has been updated to use zil prefix for testnet addresses too. So allow only that.

https://github.com/Zilliqa/Zilliqa/wiki/Address-Standard#specification

@anton-trunov
Copy link
Contributor

There is also https://github.com/Zilliqa/scilla/blob/master/src/base/BuiltIns.ml#L1004-L1005 and the relevant tests.

@vaivaswatha
Copy link
Contributor Author

There is also https://github.com/Zilliqa/scilla/blob/master/src/base/BuiltIns.ml#L1004-L1005 and the relevant tests.

Thanks for the catch @anton-trunov . Please check now.

Copy link
Contributor

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vaivaswatha vaivaswatha merged commit e73d49b into master Feb 5, 2021
@vaivaswatha vaivaswatha deleted the bech32_update branch February 5, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants