This repository has been archived by the owner on May 26, 2023. It is now read-only.
Feature/0.3 #102
Merged
Feature/0.3 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contract.prototype.deploy more flexible This addresses a long-standing issue where developers were not able to specify any address other than the default one when deploy/calling smart contracts. Tests have also been updated to provide `_scilla_version`, which is now a required parameter.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 78.71% 78.06% -0.66%
==========================================
Files 33 36 +3
Lines 794 939 +145
Branches 106 127 +21
==========================================
+ Hits 625 733 +108
- Misses 168 204 +36
- Partials 1 2 +1
Continue to review full report at Codecov.
|
edison0xyz
reviewed
Dec 18, 2018
| _tag: transition, | ||
| // TODO: this should be string, but is not yet supported by lookup. | ||
| params, | ||
| params: args, |
There was a problem hiding this comment.
Is the string supported by the current lookup now?
edison0xyz
reviewed
Dec 18, 2018
| msg = {_tag : "Main"; _recipient : _sender; _amount : Uint128 0; code : set_hello_code}; | ||
| msgs = one_msg msg; | ||
| send msgs | ||
| end |
There was a problem hiding this comment.
Do we want to standardize all helloWorld contracts with events instead of send msg?
There was a problem hiding this comment.
Currently this test contract is kept in line with whatever is on master of https://github.com/Zilliqa/scilla.
edison0xyz
approved these changes
Dec 18, 2018
mickys
approved these changes
Dec 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a number of requested features. Unfortunately, it also entails breaking changes.
Contractby allowing manual specification ofpubKey(sender) andnoncemaxAttemptsandintervaltoContractmethodsTransactionfromContract.prototype.deploytoQaandfromQautility functions to@zilliqa-js/util, as all units are nowqaRPCResponsetypes comply with the changes tolibServeron the protocol sideconst enumdeclarations were being nuked in the compiled bundle due to failure to pass inpreserveConstEnumsas a compiler option