Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

chore: update code for get pending txn #292

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

renlulu
Copy link
Contributor

@renlulu renlulu commented Apr 19, 2021

Description

Update error map for GetPendingTxn according to https://dev.zilliqa.com/docs/apis/api-transaction-get-transaction-status/

Review Suggestion

Status

Implementation

  • ready for review

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #292 (feabeea) into dev (b0d6ece) will not change coverage.
The diff coverage is n/a.

❗ Current head feabeea differs from pull request most recent head aff20df. Consider uploading reports for the commit aff20df to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #292   +/-   ##
=======================================
  Coverage   78.06%   78.06%           
=======================================
  Files          45       45           
  Lines        1682     1682           
  Branches      272      272           
=======================================
  Hits         1313     1313           
  Misses        365      365           
  Partials        4        4           
Impacted Files Coverage Δ
packages/zilliqa-js-blockchain/src/chain.ts 55.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d6ece...aff20df. Read the comment docs.

@bb111189
Copy link
Contributor

We will need to remove getpendingtxn and retain getpendingtxns

Copy link
Contributor

@bb111189 bb111189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@bb111189 bb111189 merged commit a4a8384 into dev Apr 26, 2021
@bb111189 bb111189 deleted the chore/gettransactionstatus branch August 18, 2021 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants