This repository has been archived by the owner on May 26, 2023. It is now read-only.
ESLint no-unreachable #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
AmritKumar,
bb111189,
renlulu and
teye
as code owners
ghost
force-pushed
the
refactor/no-unreachable
branch
from
04cd8c4
to
b98ee44
Compare
ghost
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #320 +/- ##
==========================================
+ Coverage 79.02% 79.19% +0.17%
==========================================
Files 45 45
Lines 1821 1817 -4
Branches 306 304 -2
==========================================
Hits 1439 1439
+ Misses 381 377 -4
Partials 1 1
Continue to review full report at Codecov.
|
bb111189
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses ESLint no-unreachable rule and removes the unreachable codes.
Review Suggestion
Status
Implementation