Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

feat: use sodium-native only #330

Merged
merged 1 commit into from
Aug 13, 2021
Merged

feat: use sodium-native only #330

merged 1 commit into from
Aug 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2021

Description

This PR changes removes @trust/webcrypto because of the following reasons:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners August 10, 2021 04:27
@ghost ghost force-pushed the feat/use-sodium-native-only branch from 2e17fa1 to 7c4a781 Compare August 10, 2021 04:28
@ghost ghost changed the title feat: use sodium-native onlly feat: use sodium-native only Aug 10, 2021
@ghost ghost closed this Aug 11, 2021
@ghost ghost reopened this Aug 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #330 (d16d494) into dev (6add1ea) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #330      +/-   ##
==========================================
+ Coverage   79.19%   79.41%   +0.21%     
==========================================
  Files          45       45              
  Lines        1817     1812       -5     
  Branches      304      300       -4     
==========================================
  Hits         1439     1439              
+ Misses        377      372       -5     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/random.ts 90.90% <100.00%> (+28.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add1ea...d16d494. Read the comment docs.

@ghost ghost force-pushed the feat/use-sodium-native-only branch from 7c4a781 to d16d494 Compare August 11, 2021 05:47
@bb111189 bb111189 merged commit b2204bc into dev Aug 13, 2021
@ghost ghost deleted the feat/use-sodium-native-only branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants