Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

refactor: no hardcoding #340

Merged
merged 1 commit into from
Aug 13, 2021
Merged

refactor: no hardcoding #340

merged 1 commit into from
Aug 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2021

Description

This PR replaces 'GetBalance' with RPCMethod.GetBalance.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners August 13, 2021 02:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #340 (63d9c75) into dev (c054901) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 63d9c75 differs from pull request most recent head 8cb52d5. Consider uploading reports for the commit 8cb52d5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #340   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          44       44           
  Lines        1787     1787           
  Branches      299      299           
=======================================
  Hits         1440     1440           
  Misses        346      346           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-account/src/wallet.ts 82.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c054901...8cb52d5. Read the comment docs.

@bb111189 bb111189 merged commit c28354c into dev Aug 13, 2021
@ghost ghost deleted the refactor/no-hardcoding branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants