Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Use sodium-universal instead of sodium-native #343

Merged
merged 3 commits into from Aug 16, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2021

Description

By using sodium-universal, this PR fixes an issue which occurs when randomBytes function is executed in the browsers.

Universal wrapper for sodium-javascript and sodium-native working in Node.js and the Browser

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners August 13, 2021 10:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #343 (95a35d7) into dev (5c2e7cd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #343   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          44       44           
  Lines        1782     1782           
  Branches      295      294    -1     
=======================================
  Hits         1440     1440           
  Misses        341      341           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/random.ts 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2e7cd...95a35d7. Read the comment docs.

@ghost ghost changed the title Use sodium-universal Use sodium-universal instead of sodium-native Aug 13, 2021
@bb111189 bb111189 merged commit 0260567 into dev Aug 16, 2021
@ghost ghost deleted the fix/use-sodium-universal branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants