Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Validate commit with pre-commit hook #348

Merged
merged 1 commit into from Aug 17, 2021
Merged

Validate commit with pre-commit hook #348

merged 1 commit into from Aug 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2021

Description

This PR runs yarn validate with pre-commit hook. yarn validate checks formatting and linting.
Therefore, you can validate changelist whenever you commit.

Motivation and Context

https://github.com/Zilliqa/Zilliqa-JavaScript-Library/runs/3346837441 failed because of lint error.
We can fail earlier and save resources by validating changes with pre-commit hook.
Screen Shot 2021-08-17 at 6 42 55 PM

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 17, 2021 09:30
@ghost ghost changed the title build: validate with pre-commit Validate with pre-commit hook Aug 17, 2021
@ghost ghost changed the title Validate with pre-commit hook Validate commit with pre-commit hook Aug 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #348 (25c2135) into dev (5a84b55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #348   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files          44       44           
  Lines        1790     1790           
  Branches      298      298           
=======================================
  Hits         1444     1444           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a84b55...25c2135. Read the comment docs.

@bb111189 bb111189 merged commit c48cfd1 into dev Aug 17, 2021
@ghost ghost deleted the feat/pre-commit branch August 17, 2021 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants