Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Use cross-fetch v2.2.5 #350

Merged
merged 1 commit into from Aug 17, 2021
Merged

Use cross-fetch v2.2.5 #350

merged 1 commit into from Aug 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2021

Description

This PR fixes #346 by using cross-fetch v2.2.5 which upgrades node-fetch to version 2.6.1

References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

Upgrade node-fetch to version 2.6.1, 3.0.0-beta.9 or higher

Closes #346
@ghost ghost requested review from AmritKumar and bb111189 as code owners August 17, 2021 10:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #350 (41e0db3) into dev (5a84b55) will not change coverage.
The diff coverage is n/a.

❗ Current head 41e0db3 differs from pull request most recent head b2ccd88. Consider uploading reports for the commit b2ccd88 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #350   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files          44       44           
  Lines        1790     1790           
  Branches      298      298           
=======================================
  Hits         1444     1444           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a84b55...b2ccd88. Read the comment docs.

@ghost ghost changed the title Fix/cross fetch v2.2.5 Use cross-fetch v2.2.5 Aug 17, 2021
@bb111189 bb111189 merged commit 11f32f1 into dev Aug 17, 2021
@ghost ghost deleted the fix/cross-fetch-v2.2.5 branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refresh lockfile to automatically remove the vulnerability introduced in @zilliqa-js/core@3.0.0
2 participants