Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Minimize jest related deps #357

Merged
merged 8 commits into from Aug 21, 2021
Merged

Minimize jest related deps #357

merged 8 commits into from Aug 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2021

Description

This PR drops jest-json-schema, jest-watch-typeahead and removes the related codes and files to minimize jest related dependencies which are non-essential.

Also it removes the old integration tests which are not included in CI.
I think we can focus on more unit testing and rewrite integration tests after that.

Motivation and Context

To upgrade Jest for #356, we will face some breaking changes. To handle those changes in simpler and easier way, we can reduce the complexity for the deps when the deps are not essential.

How has this been tested?

yarn bootstrap && yarn test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 19, 2021 08:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #357 (560aefa) into dev (519b8f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 560aefa differs from pull request most recent head 88e3bf6. Consider uploading reports for the commit 88e3bf6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #357   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          44       44           
  Lines        1804     1804           
  Branches      306      306           
=======================================
  Hits         1458     1458           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519b8f8...88e3bf6. Read the comment docs.

@ghost ghost requested a review from teye August 19, 2021 08:05
@ghost ghost force-pushed the feat/minimise-jest-related-deps branch from 54df34d to 419ecbd Compare August 19, 2021 21:28
@ghost
Copy link
Author

ghost commented Aug 19, 2021

resolved conflicts @bb111189

@ghost ghost requested review from snowsledge and renlulu as code owners August 19, 2021 22:15
@ghost ghost requested a review from bb111189 August 19, 2021 22:15
@ghost
Copy link
Author

ghost commented Aug 19, 2021

Also it removes the old integration tests which are not included in CI.
I think we can focus on more unit testing and rewrite integration tests after that.

Copy link
Contributor

@bb111189 bb111189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional commits LGTM

@bb111189 bb111189 merged commit da41e0d into dev Aug 21, 2021
@bb111189 bb111189 deleted the feat/minimise-jest-related-deps branch August 21, 2021 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants