Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

build: remove unused deps and babel-jest related deps #358

Merged
merged 3 commits into from Aug 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2021

Description

This PR removes the unused deps.
Also this removes babel-jest related deps and configs which is unnecessary.

Motivation and Context

No need to use babel.

ts-jest by default does NOT use Babel. But you may want to use it, especially if your code rely on Babel plugins to make some transformations. ts-jest can call the BabelJest processor once TypeScript has transformed the source into JavaScript.

source: https://kulshekhar.github.io/ts-jest/docs/getting-started/options/babelConfig

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 19, 2021 10:45
@ghost ghost requested a review from teye August 19, 2021 10:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #358 (ff2ffa1) into dev (db41afa) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ff2ffa1 differs from pull request most recent head 73ffc81. Consider uploading reports for the commit 73ffc81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #358      +/-   ##
==========================================
+ Coverage   80.79%   80.82%   +0.02%     
==========================================
  Files          44       44              
  Lines        1802     1804       +2     
  Branches      303      306       +3     
==========================================
+ Hits         1456     1458       +2     
  Misses        345      345              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/net.ts 98.63% <0.00%> (+0.01%) ⬆️
packages/zilliqa-js-crypto/src/keystore.ts 92.50% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db41afa...73ffc81. Read the comment docs.

@ghost ghost changed the title build: remove unused deps build: remove unused/unnessary deps Aug 19, 2021
@ghost ghost changed the title build: remove unused/unnessary deps build: remove unused or unnessary deps Aug 19, 2021
@ghost ghost changed the title build: remove unused or unnessary deps build: remove unused or unnecessary deps Aug 19, 2021
@ghost ghost changed the title build: remove unused or unnecessary deps build: remove unused deps and babel-jest related deps Aug 19, 2021
@bb111189 bb111189 merged commit e1b5981 into dev Aug 19, 2021
@bb111189 bb111189 deleted the build/remove-unused-deps branch August 19, 2021 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants