Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

refactor(crypto): use elliptic/lib/elliptic/ec/signature #386

Merged
merged 1 commit into from Sep 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2021

Description

This PR fixes #385.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners September 11, 2021 23:01
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #386 (ccc8bd4) into dev (5812a8d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #386      +/-   ##
==========================================
- Coverage   80.98%   80.92%   -0.07%     
==========================================
  Files          44       43       -1     
  Lines        1804     1798       -6     
  Branches      329      327       -2     
==========================================
- Hits         1461     1455       -6     
  Misses        342      342              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)
packages/zilliqa-js-crypto/src/schnorr.ts 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5812a8d...ccc8bd4. Read the comment docs.

@bb111189 bb111189 merged commit bf55caf into dev Sep 13, 2021
@bb111189 bb111189 deleted the refactor/signature branch September 13, 2021 06:01
@ghost ghost mentioned this pull request Nov 9, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use elliptic/lib/elliptic/ec/signature
2 participants