Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

fix(core): tx block header type #399

Merged
merged 2 commits into from Sep 24, 2021
Merged

fix(core): tx block header type #399

merged 2 commits into from Sep 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2021

Description

This PR closes #396 by adding the NumPages which was missing.
Also it removes Type which shouldn't be included in the header.
References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners September 24, 2021 05:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #399 (32ac6a6) into dev (0d43bfc) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 32ac6a6 differs from pull request most recent head d596a90. Consider uploading reports for the commit d596a90 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #399      +/-   ##
==========================================
+ Coverage   80.92%   81.08%   +0.16%     
==========================================
  Files          43       43              
  Lines        1798     1898     +100     
  Branches      327      347      +20     
==========================================
+ Hits         1455     1539      +84     
- Misses        342      358      +16     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-core/src/types.ts 100.00% <ø> (ø)
packages/zilliqa-js-blockchain/src/chain.ts 71.91% <0.00%> (+6.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d43bfc...d596a90. Read the comment docs.

@bb111189 bb111189 merged commit dda61ba into dev Sep 24, 2021
@bb111189 bb111189 deleted the fix/tx-block-header branch September 24, 2021 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TxBlockHeader is missing NumPages
2 participants