Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

refactor: isBlockNumber #405

Merged
merged 1 commit into from Sep 29, 2021
Merged

refactor: isBlockNumber #405

merged 1 commit into from Sep 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2021

Description

This PR uses isBlockNumber() to remove redundancy.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners September 27, 2021 10:07
@ghost ghost closed this Sep 27, 2021
@ghost ghost reopened this Sep 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #405 (c3794be) into dev (96c014e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c3794be differs from pull request most recent head f80809a. Consider uploading reports for the commit f80809a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #405      +/-   ##
==========================================
- Coverage   81.28%   81.27%   -0.02%     
==========================================
  Files          43       43              
  Lines        1811     1810       -1     
  Branches      334      332       -2     
==========================================
- Hits         1472     1471       -1     
  Misses        338      338              
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-blockchain/src/chain.ts 66.83% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c014e...f80809a. Read the comment docs.

@bb111189 bb111189 merged commit 89cba78 into dev Sep 29, 2021
@bb111189 bb111189 deleted the refactor/is-block-num branch September 29, 2021 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants