Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

build: remove @zilliqa-js/contract dep in @zilliqa-js/blockchain #410

Merged
merged 1 commit into from Oct 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2021

Description

This PR removes unnecessary @zilliqa-js/contract in @zilliqa-js/blockchain package.json.
When it is not removed, it creates circular dependency since #379

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners October 22, 2021 01:01
@ghost ghost changed the title build: remove @zilliqa-js/contract dep build: remove @zilliqa-js/contract dep in @zilliqa-js/blockchain Oct 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #410 (32a3cf6) into dev (67115d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #410   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      331      331           
=======================================
  Hits         1488     1488           
  Misses        322      322           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67115d0...32a3cf6. Read the comment docs.

@ghost ghost closed this Oct 22, 2021
@ghost ghost reopened this Oct 22, 2021
@ghost
Copy link
Author

ghost commented Oct 22, 2021

rebase

@bb111189 bb111189 merged commit 19839ca into dev Oct 25, 2021
@bb111189 bb111189 deleted the fix/circular-dep branch October 25, 2021 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants