Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

fix(subscriptions): d.ts file error #415

Merged
merged 1 commit into from Oct 29, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2021

Description

This PR fixes the missing d.ts files error Could not find a declaration file for module X ... in @zilliqa-js/subscriptions package since 0.8.6 version.

The cause is that subscriptions package is missing the following dependencies:

  • @types/websocket
  • mitt

The dependencies are only available in development environment.
Therefore, this PR fixes the issue by adding the missing dependencies in the subscriptions package.

You can spot these errors by running tsc --target es5 --noEmit once you install and import the subscriptions package.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners October 26, 2021 02:31
@ghost ghost requested a review from renlulu October 26, 2021 02:32
@ghost ghost mentioned this pull request Oct 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #415 (fd2fd16) into dev (b659114) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #415   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      331      331           
=======================================
  Hits         1488     1488           
  Misses        322      322           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b659114...fd2fd16. Read the comment docs.

@ghost ghost changed the title build: fix TS declaration file error Fix TS declaration file error in subscriptions pkg Oct 26, 2021
@ghost ghost changed the title Fix TS declaration file error in subscriptions pkg fix(subscriptions): d.ts file error Oct 27, 2021
@bb111189 bb111189 merged commit 35178b6 into dev Oct 29, 2021
@bb111189 bb111189 deleted the fix/ts-declaration-file-error branch October 29, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants