This repository has been archived by the owner on May 26, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the missing d.ts files error
Could not find a declaration file for module X ...
in @zilliqa-js/subscriptions package since 0.8.6 version.The cause is that
subscriptions
package is missing the following dependencies:@types/websocket
mitt
The dependencies are only available in development environment.
Therefore, this PR fixes the issue by adding the missing dependencies in the
subscriptions
package.You can spot these errors by running
tsc --target es5 --noEmit
once you install and import thesubscriptions
package.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: