Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

fix(crypto): no require import for sodium-native #428

Merged
merged 1 commit into from Nov 10, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2021

Description

This PR

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #428 (0ceb324) into dev (3c243fc) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #428      +/-   ##
==========================================
+ Coverage   82.12%   82.29%   +0.17%     
==========================================
  Files          43       44       +1     
  Lines        1807     1830      +23     
  Branches      332      334       +2     
==========================================
+ Hits         1484     1506      +22     
- Misses        322      323       +1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/random.ts 94.73% <100.00%> (ø)
packages/zilliqa-js-crypto/src/index.ts 100.00% <0.00%> (ø)
packages/zilliqa-js-crypto/src/signature.ts 88.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c243fc...0ceb324. Read the comment docs.

@bb111189 bb111189 merged commit c126b3d into dev Nov 10, 2021
@bb111189 bb111189 deleted the fix/no-require branch November 10, 2021 06:42
@ghost ghost mentioned this pull request Nov 10, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants