ZBUG-3135 zmcertmgr: make verifycrt work for non-RSA (ECDSA) certificates as well #96
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by comparing pubkey (generic) instead of modulus (RSA specific).
|
zmcertmgr createca/createcrt/createcsr should get the ability to create ECDSA certificates as well. |
|
This issue took down our production mail server as the auto-renewed letsencrypt certificates were of type ECDSA. This needs urgent fixing |
barrydegraaff
changed the title
barrydegraaff
requested review from
barrydegraaff,
Ashish-Synacor,
silentsakky,
umagmrit and
GaneshAnarse
silentsakky
approved these changes
Oct 5, 2023
|
I have validated this fix, with fixed applied I can deploy both RSA and ECDSA certificates. |
barrydegraaff
approved these changes
Oct 6, 2023
|
Great that this initial fix for deploying ECDSA certs has been approved. Will it be in the next 8.8.15/9.x/10.x patches? |
ashishkataria86
requested review from
ashishkataria86
and removed request for
ashishkataria86
umagmrit
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by comparing pubkey (generic) instead of modulus (RSA specific).