Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different Hamiltonian for xTB level of theory #28

Open
awvwgk opened this issue May 18, 2021 · 2 comments
Open

Support different Hamiltonian for xTB level of theory #28

awvwgk opened this issue May 18, 2021 · 2 comments

Comments

@awvwgk
Copy link

awvwgk commented May 18, 2021

Seems like GFN2-xTB is hardcoded as method for the xtb interface:

calc = Calculator(get_method("GFN2-xTB"), self.numbers, positions)

Being able to select the method can be useful in case GFN2-xTB is not suitable for the system of interest (hydrogen transfers). Also, a possibility to communicate charge and spin to xtb or set a higher electronic temperature would be nice here.

ms860309 added a commit to ms860309/pyGSM that referenced this issue Jun 5, 2021
@ms860309
Copy link
Contributor

ms860309 commented Jun 5, 2021

Seems like GFN2-xTB is hardcoded as method for the xtb interface:

calc = Calculator(get_method("GFN2-xTB"), self.numbers, positions)

Being able to select the method can be useful in case GFN2-xTB is not suitable for the system of interest (hydrogen transfers). Also, a possibility to communicate charge and spin to xtb or set a higher electronic temperature would be nice here.

Hi,
So, I add some args to support different xtb hamiltonian, accuracy and electronic temperature.
Default value of the xtb hamiltonian is "GFN2-xTB", accuracy is 1.0 and electronic temperature is 300.0K.
Is it reasonable for using these default values?

Jianyi

@awvwgk
Copy link
Author

awvwgk commented Jun 5, 2021

Those defaults match the standalone xtb and the Python API default, this should be a reasonable choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants