Fork or roll in changes

[ssoper]

So lots of folks have been having issues with SSZipArchive on Pods 0.39 and Swift (#185). I've got it working in a fork (https://github.com/WPMedia/WPZipArchive). I had to roll back all changes made since v0.3.3 due to some bugs that were introduced (#176, #178) and move some files around. Also did a bit of housecleaning and tests are passing again (#177).

Question is, do the maintainers want to try and pull my changes in or do we part ways and I create a new Pod, WPZipArchive, which will focus on Pods compatibility, stability and Swift interoperability?

[timkettering]

I would say go your own way. The maintainer for this project has been non-responsive for months now.

[jhudsonWA]

There are a couple of of us who are still members of the ZipArchive org. If you want to post your changes as a pull request I'll pull them in. The previous maintainer left a couple of months ago, so someone needs to pick up the torch.

The rename of the main class to Main seems to have hosed everyone and I have no idea why it was done. If you've fixed it, we should roll it in.

[ssoper]

Ok I created a branch that can be merged in. Unfortunately two more commits have been brought in to SSZipArchive master since I made my changes so a branch will need to be created off 1f7d737 and my changes can be rolled into there. Other downside is that my branch doesn't have Carthage compatibility. I attempted to install Carthage on my local machine so I could re-implement but am unable to due to lack of Swift 2 compatibility.
Carthage/Carthage#807

Here's the compare I created
1f7d737...WPMedia:feature/ssziparchive

Please let me know if I can be of any further help.

[ssoper]

Suggest you branch current master to something like 'carthage' and then update your README to reflect that for the Carthage installation instructions
github "ZipArchive/ZipArchive" "carthage"

[jhudsonWA]

Thanks @ssoper! I'll take a look at this Monday morning.

[jhudsonWA]

I reverted the two pull request I have put in. I'll merge your change in and then reapply.

[jhudsonWA]

Pull request merged in. Thanks again @ssoper. I'll look into the 'carthage' issue once 2.0 support is added. I've been waiting for it for another project.

[ssoper]

Excellent! Don't forget to push the pod (0.4.0) ⛵

[jhudsonWA]

I will try. Need to figure out if I have the correct rights on the pods side of things.

Sent from my iPhone

On Oct 24, 2015, at 4:53 PM, Sean Soper notifications@github.com wrote:

Excellent! Don't forget to push the pod (0.4.0)

—
Reply to this email directly or view it on GitHub.

[inamiy]

Thanks for this great fix! ⭐⭐⭐⭐⭐ to @ssoper !

BTW, is Carthage support still existing?
If not, we might want to have another xcodeproj for just building framework (not from CocoaPods).

And please pod trunk push :)

[jhudsonWA]

I'll try to first thing in the morning. Need to get to my Mac.

Also for Carthage we will tackle that next.

Sent from my iPhone

On Oct 25, 2015, at 7:06 PM, Yasuhiro Inami notifications@github.com wrote:

Thanks for this great fix! to @ssoper !

BTW, is Carthage support still existing?
If not, we might want to have another xcodeproj for just building framework (not from CocoaPods).

And please pod trunk push :)

—
Reply to this email directly or view it on GitHub.