fix compile errors for Xcode 10.2 and esp. Swift 5 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @DivineDominion and @Coeur |
|
Great! Now that it's merged, will there be a point-release once the Travis build is functional again? |
|
@DivineDominion yes, in a few hours. I'm working on the travis builds first. [edit] tag done: I'm releasing now. |
|
@Coeur you're the best 🙌 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though no Swift is used, the
SWIFT_VERSIONbuild setting caused the build tools to grind to a halt with the latest Xcode 10.2. I removed the offending setting and updated the project to conform to Xcode 10.2's new recommendations.