add support for compressing symbolic link files #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR which add support for compressing symbolic link files is used to fix issue #551. |
willson-chen
force-pushed
the
add_symlink
branch
from
40c608f
to
7547437
Compare
willson-chen
commented
Mar 20, 2020
| zipInfo.external_fa = src_attrib; | ||
| } | ||
|
|
||
| uint16_t version_madeby = 3 << 8;//UNIX |
There was a problem hiding this comment.
Only 3 << 8 is avaible to zip symlink. If it is changed to 19 << 8, the symlink file will be zipped failed, which puzzles me.
There was a problem hiding this comment.
Did you ever solve this puzzle? I went ahead and merged in as everything looked good and tests passed.
This was
linked to
issues
Apr 1, 2020
willson-chen
force-pushed
the
add_symlink
branch
from
61b823a
to
ac6e405
Compare
willson-chen
force-pushed
the
add_symlink
branch
from
2231405
to
0dc4051
Compare
jhudsonWA
added a commit
that referenced
this pull request
May 29, 2021
This was referenced May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.