Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gitaction build #576

Merged
merged 2 commits into from May 31, 2021
Merged

Added gitaction build #576

merged 2 commits into from May 31, 2021

Conversation

willson-chen
Copy link
Member

Added gitaction build and show code coverage.

@MoNTE48
Copy link

MoNTE48 commented Apr 18, 2021

@jhudsonWA, can this be merged?

@jhudsonWA
Copy link
Member

Good question. @willson-chen can you confirm this build still works on your fork with any and all GitHub action changes? Plus, we wouldn't really need both travis and actions if adopted as long as the supported features were the same.

@jhudsonWA
Copy link
Member

jhudsonWA commented May 31, 2021

I'm going to merge this in, and will eventually be phasing out travis-ci.

Actions have limitations to our current travis builds (less older version of Xcode and OSs are supported), but as of 5/31 Travis is phasing out travis-ci.org (which we got unlimited build minutes on) to travis-ci.com. On .com we have to apply for credits and then they give a set amount (we were given 25000). Our issue is with the current setup we will burn through 5000 credits per build.

Given that, I don't think travis-ci has a future with our project. I'll modify the action to test on as old of versions of Xcode/OSs as actions images support, but it won't be back to as far as travis supports now.

@jhudsonWA jhudsonWA merged commit ad55eaa into ZipArchive:master May 31, 2021
@jhudsonWA
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants