Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.0 - Upgrade minizip to minizip-ng 3.0.2 #613

Merged
merged 8 commits into from May 29, 2021
Merged

Conversation

jhudsonWA
Copy link
Member

New name, also updated readme's to point to new location for this project.

@jhudsonWA jhudsonWA requested a review from Coeur May 29, 2021 02:02
@jhudsonWA
Copy link
Member Author

jhudsonWA commented May 29, 2021

@Coeur minizip name changed since our last upgrade. They also are now at 3.x based releases. As far as I can tell the main functionality seems the same. This PR updates readme's and such to match the new location.

Also, just for you, following the Release Instructions results in flags that want you to switch to libcomp instead of zlib, at least when I did it. [I added notes to the master copy of this file to ignore those flags and files for now and stick with zlib]

Following this switch would require a bump to our supported platforms (at least mac os 10.11+). I'm ok with that, but that type of change should be a 3.x change for us as that would be breaking for older versions, so for now I kept the flags to be zlib and all tests pass for this upgrade.

Please give it a review.

@jhudsonWA
Copy link
Member Author

bumping version to 2.4.0 as we will have other changes in this release (no breaking) and with the major version upgrade in minizip. Feels more than just a 2.3.x point release.

@jhudsonWA jhudsonWA removed the request for review from Coeur May 29, 2021 15:32
@jhudsonWA jhudsonWA changed the title 2.3.1 - Upgrade minizip to minizip-ng 3.0.2 2.4.0 - Upgrade minizip to minizip-ng 3.0.2 May 29, 2021
@jhudsonWA jhudsonWA merged commit 414a56b into master May 29, 2021
@jhudsonWA jhudsonWA deleted the minizip-ng-3.0.2 branch May 29, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant