Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matches different import modes #617

Merged
merged 1 commit into from Jun 3, 2021
Merged

Conversation

CLJian
Copy link

@CLJian CLJian commented Jun 3, 2021

My project can not run. Import modes is not correct.

@BearRan
Copy link

BearRan commented Jun 3, 2021

Yep. I have the same problem.

@jhudsonWA
Copy link
Member

How are you integrating this library into your project? Cocoapods? What version?

Also what version of Xcode?

Swift Project, or Pure Obj C?

This is not a bad way to handle the includes, but I want to understand the different ways the project is used before we put in all of these workarounds.

2.4.1 was tested using a clean SPM test app, and a clean cocoapods test app before it was released (using the latest cocoapods), so I know they no longer step on each other with a standard configuration.

@jhudsonWA
Copy link
Member

I'm going to merge this in as it should be harmless, but I still would like my questions answered so I know.

@jhudsonWA jhudsonWA merged commit f1874a8 into ZipArchive:master Jun 3, 2021
@jhudsonWA
Copy link
Member

Pushed out and released as 2.4.2

@CLJian
Copy link
Author

CLJian commented Jun 4, 2021

My project is Pure Obj C,using CocoaPods. The way you originally wrote it depends on the file path. With CocoaPods installation, the file path will disappear.

@jhudsonWA
Copy link
Member

Thanks for the update, but I have a test pure obj c project using Cocoapods, that pulled down from 2.4.1 and it built fine. I did see that it flattened the folder structure but still built, so I figured we were golden.

Anyway, thank you for the PR, I think we are stable now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants