Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special-case the handling of DB Cluster- and DB Instance-level metrics in RDS #4

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

ripta
Copy link
Contributor

@ripta ripta commented Sep 25, 2019

Specifically, with a configuration like such:

[[exportconfigs]]

   namespace = "AWS/RDS"
   name = "CPUUtilization"
   dimensionsMatch   = { DBInstanceIdentifier = "..."    }
   dimensions = ["DBInstanceIdentifier"]
   statistics = ["Average"]

[[exportconfigs]]

   namespace = "AWS/RDS"
   name = "CPUUtilization"
   dimensionsMatch   = { DBClusterIdentifier = "..."    }
   dimensions = ["DBClusterIdentifier" , "Role"]
   statistics = ["Average"]

the previous behavior would have generated the following error:

Namespace=AWS/RDS Name=CPUUtilization: a previously registered descriptor with the same fully-qualified name as Desc{fqName: "aws_rds_utilization_average", help: "", constLabels: {}, variableLabels: [cluster_identifier role]} has different label names or a different help string

The patch would allow the configuration above, with the caveat that metrics are now renamed from, e.g., aws_rds_utilization_average{instance_identifier="shared"} to aws_rds_utilization_instance_average{instance_identifier="shared"}. Similarly, a cluster would have _cluster instead of _instance.

@frioux frioux merged commit 8440711 into ZipRecruiter:master Sep 25, 2019
@ripta ripta deleted the rds-ununique-metric branch September 25, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants