Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/friction less onboarding and usage reporting #256

Merged
merged 45 commits into from
Apr 29, 2024
Merged

Feat/friction less onboarding and usage reporting #256

merged 45 commits into from
Apr 29, 2024

Conversation

johnyrahul
Copy link
Contributor

@johnyrahul johnyrahul commented Apr 12, 2024 •
edited

What

  • Adding usage data to individual tenant-specific schema
  • Introduce org level adapters
  • Moved socket message subscription to the global level.
  • Validating adapter to check to see if it is usable.

TODO items:

  • Add the SDK-published version. This change is required to pass the adapter instance id while pushing usage data @Deepak-Kesavan
  • Add updated pdm.lock file

Database Migrations

  • Adapter instance 4 new columns added with default values. No data migration is required
  • Added a field in the organization table for max token count set defaulted with -1. No data migration is required

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

@johnyrahul johnyrahul changed the title Feat/friction less onboarding WIP: Feat/friction less onboarding Apr 12, 2024
@johnyrahul johnyrahul changed the title WIP: Feat/friction less onboarding WIP: Feat/friction less onboarding and usage reporting Apr 23, 2024
@johnyrahul johnyrahul marked this pull request as ready for review April 26, 2024 07:52
@johnyrahul johnyrahul changed the title WIP: Feat/friction less onboarding and usage reporting Feat/friction less onboarding and usage reporting Apr 26, 2024
tahierhussain
tahierhussain approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@tahierhussain tahierhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes looks good, except one minor change.

frontend/src/components/widgets/list-view/ListView.jsx Show resolved Hide resolved
chandrasekharan-zipstack
chandrasekharan-zipstack reviewed Apr 27, 2024
View reviewed changes
backend/account/authentication_controller.py Outdated Show resolved Hide resolved
backend/account/authentication_helper.py Show resolved Hide resolved
backend/account/user.py Show resolved Hide resolved
backend/adapter_processor/models.py Outdated Show resolved Hide resolved
backend/adapter_processor/models.py Show resolved Hide resolved
backend/prompt_studio/prompt_studio_core/views.py Show resolved Hide resolved
backend/pyproject.toml Show resolved Hide resolved
hari-kuriakose
hari-kuriakose approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnyrahul Migrations look good overall.

However left one suggestion regarding naming of a particular db column.

backend/usage/migrations/0001_initial.py Show resolved Hide resolved
johnyrahul and others added 2 commits April 29, 2024 10:29
@johnyrahul @chandrasekharan-zipstack
Update backend/adapter_processor/models.py
5dffc24 
Co-authored-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
Signed-off-by: Rahul Johny <116638720+johnyrahul@users.noreply.github.com>
@johnyrahul
Addressed the review comments
40f5ce2
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nehabagdia nehabagdia merged commit 9d49cdb into main Apr 29, 2024
4 checks passed
@nehabagdia nehabagdia deleted the feat/friction_less_onboarding branch April 29, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahierhussain tahierhussain tahierhussain approved these changes

@nehabagdia nehabagdia nehabagdia approved these changes

@chandrasekharan-zipstack chandrasekharan-zipstack chandrasekharan-zipstack approved these changes

@hari-kuriakose hari-kuriakose hari-kuriakose approved these changes

@harini-venkataraman harini-venkataraman Awaiting requested review from harini-venkataraman

@gaya3-zipstack gaya3-zipstack Awaiting requested review from gaya3-zipstack

@Deepak-Kesavan Deepak-Kesavan Awaiting requested review from Deepak-Kesavan

Assignees

@johnyrahul johnyrahul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@johnyrahul @tahierhussain @nehabagdia @chandrasekharan-zipstack @hari-kuriakose @Deepak-Kesavan