Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added log and raise exeception in domain validation #277

Merged
merged 6 commits into from
May 3, 2024

Conversation

vishnuszipstack
Copy link
Contributor

@vishnuszipstack vishnuszipstack commented Apr 23, 2024

What

  • Added log and exception handling for domain validation

Why

  • Error code was not added to handle domain validation

How

  • Added error codes for the domain validations errors like disposable email error and invalid email

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

  • Cloud PR-78

Dependencies Versions

Notes on Testing

Screenshots

disposible

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nehabagdia nehabagdia merged commit a0e052b into main May 3, 2024
4 checks passed
@nehabagdia nehabagdia deleted the fix/exception-handling-auth branch May 3, 2024 10:18
@@ -35,6 +35,14 @@ function GenericError() {
subtitle:
"You'll need to contact the admin of your organization's account to get access.",
},
INE001: {
title: `Email not allowed`,
subtitle: "Disposible emails not allowed.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnuszipstack there's a typo, it should be Disposable here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants