Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed index key generation in prompt service #309

Merged
merged 2 commits into from
May 3, 2024

Conversation

chandrasekharan-zipstack
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented May 3, 2024

What

  • Typed chunk size and chunk overlap as str - to remain consistent with how its indexed

Why

  • Inconsistency in types result in different hashes, raising an SDK PR to handle this uniformly
    image

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, it only has minor log updates and an update for indexing correctly

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

  • Tried indexing and executing a prompt

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hari-kuriakose hari-kuriakose merged commit dadf378 into main May 3, 2024
4 checks passed
@hari-kuriakose hari-kuriakose deleted the fix/prompt-service-index-key-gen branch May 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants