FEAT: PostHog Custom Events #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahierhussain
requested review from
Deepak-Kesavan,
athul-rs,
jagadeeswaran-zipstack,
mohamed-siddhiq,
nehabagdia,
vishnuszipstack and
hari-kuriakose
…nstract into feature/posthog-custom-events
Deepak-Kesavan
approved these changes
May 4, 2024
frontend/src/components/input-output/configure-ds/ConfigureDs.jsx
Outdated
Show resolved
Hide resolved
|
nehabagdia
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added the required posthog custom events.
Why
The default PostHog events that were being triggered were too noisy. Therefore, to avoid this issue, we disabled the default capture and created our custom events, adding them only where necessary.
How
Posthog provides us to create custom events. Read more.
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Yes. This PR has the potential to break existing features in the FE. Prior to this PR, in some instances, the onClick value was directly modified within the JSX part. For example: onClick={() => setData()}. However, including the posthog function call directly within the JSX part wouldn't be ideal. To address this, I've created a new function in such cases and refactored the code accordingly. But I have tested such cases thoroughly to make sure any existing features don't break.
Database Migrations
NA
Env Config
NA
Relevant Docs
https://posthog.com/docs/libraries/react
Related Issues or PRs
Cloud PR: https://github.com/Zipstack/unstract-cloud/pull/82
Dependencies Versions
NA
Notes on Testing
NA
Screenshots
NA
Checklist
I have read and understood the Contribution Guidelines.