Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed name to close all in notification component #314

Merged
merged 4 commits into from
May 6, 2024

Conversation

jagadeeswaran-zipstack
Copy link
Contributor

What

  • Changed destroy all button name to close all

Why

  • Close all will be more appropriate here

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • No, This is UI change that won't affect any feature

Database Migrations

  • NA

Env Config

  • NA

Relevant Docs

  • NA

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@tahierhussain tahierhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frontend/src/App.jsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nehabagdia nehabagdia merged commit 83cf9af into main May 6, 2024
4 checks passed
@nehabagdia nehabagdia deleted the destroy-all-button-name-change branch May 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants